Skip to content

Conversation

@kaz
Copy link

@kaz kaz commented Nov 14, 2025

Description

Added all missing translations for the ja-JP locale.
Also reviewed existing entries and fixed any mistranslations or unnatural expressions wherever possible.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: localization

Summary by CodeRabbit

  • Localization
    • Significantly expanded Japanese (ja-JP) translations across the platform, including API key management, billing and payment operations, organization administration, domain verification, authentication flows (sign-in, sign-up, MFA, password recovery), user profiles, form fields, error messages, and UI navigation. Replaced numerous previously undefined values with complete Japanese strings.

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: d76c987

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 14, 2025

@kaz is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

A patch version changelog entry is added for @clerk/localizations, and extensive Japanese (ja-JP) localization strings are introduced, replacing previously undefined or placeholder values across API keys, billing, organization management, authentication flows, and user account sections.

Changes

Cohort / File(s) Summary
Changelog Entry
.changeset/icy-crabs-smile.md
Patch version bump entry documenting Japanese translation improvements.
Localization Translations
packages/localizations/src/ja-JP.ts
Comprehensive population of the jaJP localization object with Japanese translations for previously undefined fields spanning apiKeys, billing, paymentMethod, organization management, authentication flows, user profiles, forms, error messages, and UI navigation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Primary effort is spot-checking translation accuracy and verifying key-value pairs are correctly placed within the nested structure
  • Changes follow a consistent, homogeneous pattern (string value additions and updates)
  • Changelog entry requires minimal review

Poem

🐰 ✨ Japanese whispers now fill the code,
Where once were gaps, translations flowed,
From apiKeys to billing's dance,
Each string finds its rightful stance,
The jaJP locale takes its bow! 🎭

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'feat(localizations): Improve Japanese (ja-JP) translations' directly and clearly summarizes the main change: comprehensive improvements to Japanese locale translations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d32d724 and d76c987.

📒 Files selected for processing (2)
  • .changeset/icy-crabs-smile.md (1 hunks)
  • packages/localizations/src/ja-JP.ts (35 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (4)
.changeset/icy-crabs-smile.md (1)

1-5: LGTM!

The changeset properly documents the patch version bump with an appropriate description matching the PR objectives.

packages/localizations/src/ja-JP.ts (3)

233-233: Verify if username placeholder should have a translation.

The formFieldInputPlaceholder__username field is set to undefined while surrounding placeholder fields (lines 217-232) have Japanese translations. Given the PR objective to add "all missing translations," please confirm whether this is intentional or if a translation like 'ユーザー名を入力' should be added.


747-747: Verify if subtitleCombined requires translation.

The subtitleCombined field is set to undefined while the related fields subtitle (line 746) and titleCombined (line 749) have Japanese translations. Please confirm whether this field should remain undefined or needs a translation for completeness.


878-934: Verify undefined error messages in unstable__errors section.

Multiple error message keys in the unstable__errors section remain undefined (lines 878, 881-892, 897, 904-909, 933-934), including important error cases like:

  • captcha_invalid
  • form_code_incorrect
  • form_password_incorrect
  • form_identifier_not_found
  • form_param_format_invalid

Given the PR objective to add "all missing translations," please confirm whether these undefined values are:

  1. Intentional (these errors are handled differently or not applicable to ja-JP)
  2. Still pending translation

If these are pending, some suggested translations for critical errors:

  • captcha_invalid: 'CAPTCHAが無効です'
  • form_code_incorrect: 'コードが正しくありません'
  • form_password_incorrect: 'パスワードが正しくありません'
  • form_identifier_not_found: '識別子が見つかりません'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants