Draft
Conversation
- `DbConnectionBuilder::build` becomes async without tokio's block_in_place. Still need to add `web` feature flag.
Renamed the `run_threaded` method on `wasm32` to better reflect its behavior of spawning a background task. The generated `DbConnection` methods `run_threaded`, `run_background`, and `advance_one_message_blocking` now include runtime panics with a clear error feedback when called on unsupported targets.
Trim down repetitive `cfg` clauses by extracting common lock patterns into `get_lock_[sync|async]`.
Moves the creation of DbContextImplInner and DbContextImpl into private helper functions (`build_db_ctx_inner` and `build_db_ctx`) to reduce duplication between the web and non-web implementations of `build_impl`.
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Mar 13, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
…o bfops/wasm-update
…dk-updated' into bfops/wasm-test
bfops
commented
Mar 16, 2026
| // These types determine the size of [`parse_expr`]'s stack frame. | ||
| // These types determine the size of [`parse_expr`]'s stack frame on 64-bit targets. | ||
| // Changing their sizes will require updating the recursion limit to avoid stack overflows. | ||
| // wasm32 has different type layouts, so this guard does not apply there. |
Collaborator
Author
There was a problem hiding this comment.
I would like a (human) reviewer's input here on whether it is reasonable to omit these checks given the comment about stack overflows.
bfops
commented
Mar 16, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Mar 16, 2026
| .map_err(|source| CredentialFileError::Deserialize { path, source })?; | ||
| Ok(Some(creds.token)) | ||
| #[cfg(feature = "web")] | ||
| mod web_mod { |
Collaborator
Author
There was a problem hiding this comment.
we should add some tests for this
…worklabs/SpacetimeDB into bfops/wasm-test
…386ad0' into bfops/wasm-update
…dk-updated' into bfops/wasm-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Real questions remaining:
API and ABI breaking changes
Expected complexity level and risk
Testing