Skip to content

Fix useTable isReady reverting to false after first row event #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfops merged 5 commits into from
Mar 13, 2026
Merged

Fix useTable isReady reverting to false after first row event #4580

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfcbc3d
Fix useTable isReady reverting to false after first row event (#4559)
clockwork-labs-bot Mar 6, 2026
96628c6
Merge branch 'master' into bot/fix-usetable-isready-stale
bfops Mar 10, 2026
de279e4
Apply suggestion from @bfops
bfops Mar 13, 2026
671c1b6
Apply suggestion from @bfops
bfops Mar 13, 2026
f5b580c
Merge branch 'master' into bot/fix-usetable-isready-stale
bfops Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/bindings-typescript/src/react/useTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ export function useTable<TableDef extends UntypedTableDef>(
) as Prettify<UseTableRowType>[])
: (Array.from(table.iter()) as Prettify<UseTableRowType>[]);
return [result, subscribeApplied];
// TODO: investigating refactoring so that this is no longer necessary, as we have had genuine bugs with missed deps.
// See https://github.com/clockworklabs/SpacetimeDB/pull/4580.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [connectionState, accessorName, querySql, subscribeApplied]);

Expand Down Expand Up @@ -205,11 +207,14 @@ export function useTable<TableDef extends UntypedTableDef>(
table.removeOnUpdate?.(onUpdate);
};
},
// TODO: investigating refactoring so that this is no longer necessary, as we have had genuine bugs with missed deps.
// See https://github.com/clockworklabs/SpacetimeDB/pull/4580.
// eslint-disable-next-line react-hooks/exhaustive-deps
[
connectionState,
accessorName,
querySql,
computeSnapshot,
callbacks?.onDelete,
callbacks?.onInsert,
callbacks?.onUpdate,
Expand Down
Loading