Fix issue of trying to decode a str#455
Merged
petrutlucian94 merged 2 commits intoJul 21, 2026
Merged
Conversation
This fixes an error where _parse_iface_file tries to decode a str. The output of the command getting executed is already getting decoded in coriolis/utils.py exec_cmd_ssh introduced in commit 539fabb
Member
|
Thanks for sending the fix! It seems like this was indeed an oversight in 539fabb. There's an unit test that will need to be updated before being able to merge the fix but I'll take care of that. |
"_read_file_sudo" no longer returns a byte array, it actually decodes the string. The tests need to be updated accordingly, avoiding type mismatches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error where _parse_iface_file tries to decode a str. The output of the command getting executed is already getting decoded in coriolis/utils.py exec_cmd_ssh introduced in commit 539fabb