Add version-specific support utilities for RHEL-family tools#474
Open
mihaelabalutoiu wants to merge 1 commit into
Open
Add version-specific support utilities for RHEL-family tools#474mihaelabalutoiu wants to merge 1 commit into
mihaelabalutoiu wants to merge 1 commit into
Conversation
Add dynamic version detection to RHEL-family OSMorphing tools, enabling support for RHEL 6-10+ through unified implementations. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
marked this pull request as ready for review
July 21, 2026 10:28
petrutlucian94
approved these changes
Jul 21, 2026
petrutlucian94
left a comment
petrutlucian94
left a comment
Member
There was a problem hiding this comment.
This trivial helper is worth having. If we'll ever need to parse semver and retrieve the minor version or patch version, we can use packaging.version: https://packaging.pypa.io/en/latest/version.html
| if not match: | ||
| raise ValueError( | ||
| "Could not parse major version from release string: %r" | ||
| % (version,)) |
Member
There was a problem hiding this comment.
Passing a tuple when formatting a single value is a bit unusual but still correct. There's also the option to use format strings, e.g. f"Could not parse major version from release string: {version}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces dynamic version detection to RHEL-family OSMorphing tools enabling support for RHEL 6-10+ through unified implementations.