Skip to content

Add a method to know if providers support or not shared disks in clustered transfers#476

Open
fabi200123 wants to merge 1 commit into
cloudbase:masterfrom
fabi200123:shared-disks-check
Open

Add a method to know if providers support or not shared disks in clustered transfers#476
fabi200123 wants to merge 1 commit into
cloudbase:masterfrom
fabi200123:shared-disks-check

Conversation

@fabi200123

Copy link
Copy Markdown
Contributor

This PR adds the following:

  • a method for providers (supports_shared_disks) to know if they have implemented the support for shared disks or not

@fabi200123
fabi200123 force-pushed the shared-disks-check branch from d02554d to d0b54ec Compare July 22, 2026 10:43
Destination import providers that can attach the same volume to
multiple instances (e.g. Libvirt ``<shareable/>``) should override
this to return ``True``. Defaults to ``False``.
"""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add the following since the ability to attach the volumes to multiple instances isn't all that's required on the provider side.

In order to coordinate shared disk operations, the conductor will mark one of the instances
as owner of the shared disk.

As such, operations such as disk creation, deletion, resize or data migration should be handled
by tasks that are targeting the owner instance.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@fabi200123
fabi200123 force-pushed the shared-disks-check branch from d0b54ec to bead71f Compare July 22, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants