Add ProxyConfig to the bootstrap params - #56
Merged
Conversation
This change adds a ProxyConfig section to BootstrapInstance{}, which
injects a bootcmd in cloud-init config, which configures the local
package manager of the runner. This is meant to enable proxy settings
in the early package update plugin and in the packages plugin of
cloud-init.
The user script used by GARM will have its own proxy section and will be
generated by GARM itself. We should deprecate the runner install template
in the garm-provider-common package as it is severely outdated, does not
have gitea support and is dificult to update.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a ProxyConfig section to BootstrapInstance{}, which injects a bootcmd in cloud-init config, which configures the local package manager of the runner. This is meant to enable proxy settings in the early package update plugin and in the packages plugin of cloud-init.
The user script used by GARM will have its own proxy section and will be generated by GARM itself. We should deprecate the runner install template in the garm-provider-common package as it is severely outdated, does not have gitea support and is dificult to update.