feat: implement http bindings #251
Conversation
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
|
@xSAVIKx Can you please have a look when you are available 🙏 |
| normalized_headers = _normalize_headers(message.headers) | ||
|
|
||
| attributes: Dict[str, Any] = {} | ||
|
|
||
| for header_name, header_value in normalized_headers.items(): | ||
| if header_name.startswith(CE_PREFIX): | ||
| attr_name = header_name[len(CE_PREFIX) :] | ||
| attributes[attr_name] = _decode_header_value(attr_name, header_value) |
There was a problem hiding this comment.
While this is factually a correct way we should take into account that CE are kinda low-level transport protocol messages. Creating a lot of intermediate objects here like doing this headers normalization may look like a small thing but will lead to bloating up resources consumption and while this is some new code, it may be a good opportunity to also think about doing this in an optimal way when possible.
it may be better to have a single for loop and do all the checks we want (CE-prefixed headers, content type header, etc) in a single run to avoid extra data structured and extra lookups.
There was a problem hiding this comment.
That's fair. Let me see what can I do.
There was a problem hiding this comment.
Done. Let me know if it's better
Signed-off-by: Tudor Plugaru <[email protected]>
…udor/add-http-bindings
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
Signed-off-by: Tudor Plugaru <[email protected]>
|
@xSAVIKx this is ready again. I think I addressed your comments. Can you please review 🙏 |
2 participants
Changes
One line description for the changelog