fix(think): label channel speakers in messenger messages#1907
Open
cjol wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 5f09f0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Action events now follow the same channel-only rule as regular messages: labelled in channels, unlabelled in DMs. The speaker label only serves to disambiguate multiple humans, which cannot happen in a 1:1 DM. Co-Authored-By: Beta-Devin AI <248786709+beta-devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configurable speaker labels for
@cloudflare/thinkmessenger channel traffic and documents the defaultSpeakerName: texttranscript shape. Fixes #1840.Why
Name: textas an identity cue instead of speaker attribution, especially when the user message is short or the agent persona is strict.nullto suppress a channel label for a specific author.Public API Surface
MessengerDefinition.channelSpeakerLabelChannelSpeakerLabelstring | null | undefined.resolveChannelSpeakerLabel@cloudflare/think/messengers.toMessengerUserMessage(event, channelSpeakerLabel?)Code Changes
events.tscentralizes the channel speaker fallback cascade asfullName || userName || userIdand treatsnullor an empty formatter result as label suppression.toMessengerUserMessageapplies speaker labels only for non-DM threads, for both text messages and action events.chat-sdk.tsthreadschannelSpeakerLabelfrom each messenger definition into the model-facing message conversion path.@cloudflare/thinkfor a minor release because the messenger definition API gains a new option.Compatibility
SpeakerName: textusingfullName || userName || userId.