fix(think): resolve messenger self-mentions#1920
Open
cjol wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 03e5e8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites Think messenger self-mentions before they reach the model. It replaces the bot's own unresolved raw user-id mention with the configured bot handle in Chat SDK messenger events.
Why
@U0BD9EYL52S, after adapters resolve other users to readable names.userNamemessenger option already represents the readable bot handle, so the fix can reconstruct@<userName>without adding configuration.botUserId; handle-based adapters already produce readable mentions and are left unchanged.Public API Surface
resolveSelfMention@cloudflare/think/messengersthat rewrites<@id>,<@!id>, and bare@idself-mentions to@<userName>.Code Changes
defaultChatSdkEventnow normalizes the message once, rewrites the bot self-mention, and passes the rewritten message into the messenger event.resolveSelfMentionhandles Slack and Discord angle-bracket mention forms plus the bare@idform some adapters normalize to.@cloudflare/think.