fix(mcp): recover expired HTTP sessions#1923
Open
mattzcarey wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 2ff3881 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The MCP SDK skips initialization when given a persisted session id. If the server expired that session while the Durable Object slept, restore appeared connected but every discovery request returned 404. Because the id remained persisted, the same unusable session came back on every wake.
Recovery is deliberately narrow: it only handles the SDK's
StreamableHTTPErrorwith status 404 while probing a restored session. A JSON-RPC application error with code 404, or an HTTP 404 on a session negotiated in the current lifetime, does not trigger a reconnect.Review follow-up
code: 404to the SDK's actualStreamableHTTPError, avoiding collisions with JSON-RPC application errorsValidation
pnpm --filter agents exec vitest run src/tests/mcp— 30 files, 536 tests passedpnpm run check— passedIncludes a patch changeset for
agents.