-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[WAI] New Qwen models + API script fix #26510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://41758c2a.preview.developers.cloudflare.com Files with changes (up to 15)
|
craigsdennis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a little more info on what this is solving. The changes to the script, shouldn't be necessary. I think the API should be doing what you are attempting here probably.
Documentation on at least why would be required.
|
|
||
| // Check which models are still missing valid schemas | ||
| const modelsWithoutSchema = Array.from(accumulatedModels.values()).filter( | ||
| (model) => !hasValidSchema(model), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because the API isn't returning the same model twice?
| /** | ||
| * Check if a model has a valid schema | ||
| */ | ||
| function hasValidSchema(model) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would the API return an invalid schema @thatsKevinJain
| if (accumulatedModels.has(model.name)) { | ||
| // Merge with existing model data | ||
| const existing = accumulatedModels.get(model.name); | ||
| const merged = deepMerge(existing, model); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is order based overrides?
| "description": "Feature extraction models transform raw data into numerical features that can be processed while preserving the information in the original dataset. These models are ideal as part of building vector search applications or Retrieval Augmented Generation workflows with Large Language Models (LLM)." | ||
| }, | ||
| "created_at": "2025-09-03 20:48:38.784", | ||
| "created_at": "2025-09-04 16:38:44.980", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note there are two of these models?
| "type": "number", | ||
| "description": "Confidence that this word was transcribed correctly" | ||
| "end_of_turn_confidence": { | ||
| "type": "number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hand coded?
| @@ -0,0 +1,111 @@ | |||
| { | |||
| "id": "cb254e3b-372b-4d4e-8526-ada79940427a", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest doing this in a separate commit.
Summary