You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR is clean and straightforward. Let me assess:
@types/node added to 3 Angular examples — Correct fix. Angular CLI 15 with @angular-devkit/build-angular often needs Node type definitions. Version ^18.0.0 is appropriate for Angular 15 era. All three examples are treated consistently.
pnpm build added to root package.json — Uses pnpm -r run build. This is fine — pnpm -r run skips packages without a matching script by default, and the investigation shows all workspace members actually have a build script anyway.
AGENTS.md updated — Documents the new pnpm build command. Consistent with the rest of the docs section.
pnpm-lock.yaml — Resolves to @types/node@18.19.130 with undici-types@5.26.5 dependency. Lockfile is consistent.
Recording SDK Angular examples — These don't have @types/node either, but they're separate workspace packages with their own deploy pipelines and might not have the same CI issue. This is out of scope for this PR's stated goal.
One minor concern: the root pnpm -r run build (without --if-present) would fail if any workspace member lacks a build script, but based on investigation all current members have one. This is a low-risk convention difference, not a bug.
This PR is clean — it's a targeted CI fix with consistent changes across all three Angular examples.
The PR is straightforward: it adds @types/node as a devDependency to three Angular examples and updates the lockfile accordingly. The changes are consistent across all three packages, the version specifier (^18.0.0) is appropriate for Angular 15, and the lockfile resolves correctly.
There are no bugs, security issues, performance problems, or style concerns. The change is a minimal, targeted CI fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.