Skip to content

fix(angular-build): fixed node types to avoid ci issues - #93

Merged
ravindra-cloudflare merged 2 commits into
stagingfrom
fix/angular-build
Jul 13, 2026
Merged

fix(angular-build): fixed node types to avoid ci issues#93
ravindra-cloudflare merged 2 commits into
stagingfrom
fix/angular-build

Conversation

@ravindra-cloudflare

Copy link
Copy Markdown
Collaborator

No description provided.

@ravindra-cloudflare
ravindra-cloudflare requested a review from a team July 13, 2026 09:30
@ask-bonk

ask-bonk Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

The PR is clean and straightforward. Let me assess:

  1. @types/node added to 3 Angular examples — Correct fix. Angular CLI 15 with @angular-devkit/build-angular often needs Node type definitions. Version ^18.0.0 is appropriate for Angular 15 era. All three examples are treated consistently.

  2. pnpm build added to root package.json — Uses pnpm -r run build. This is fine — pnpm -r run skips packages without a matching script by default, and the investigation shows all workspace members actually have a build script anyway.

  3. AGENTS.md updated — Documents the new pnpm build command. Consistent with the rest of the docs section.

  4. pnpm-lock.yaml — Resolves to @types/node@18.19.130 with undici-types@5.26.5 dependency. Lockfile is consistent.

  5. Recording SDK Angular examples — These don't have @types/node either, but they're separate workspace packages with their own deploy pipelines and might not have the same CI issue. This is out of scope for this PR's stated goal.

One minor concern: the root pnpm -r run build (without --if-present) would fail if any workspace member lacks a build script, but based on investigation all current members have one. This is a low-risk convention difference, not a bug.

This PR is clean — it's a targeted CI fix with consistent changes across all three Angular examples.

LGTM!

github run

@ask-bonk

ask-bonk Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

The PR is straightforward: it adds @types/node as a devDependency to three Angular examples and updates the lockfile accordingly. The changes are consistent across all three packages, the version specifier (^18.0.0) is appropriate for Angular 15, and the lockfile resolves correctly.

There are no bugs, security issues, performance problems, or style concerns. The change is a minimal, targeted CI fix.

LGTM!

github run

@ravindra-cloudflare
ravindra-cloudflare merged commit 823b66a into staging Jul 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants