Skip to content

[Cherry-pick][main] Fix missing completion for 'SpaceSupporter' #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Cherry-pick][main] Fix missing completion for 'SpaceSupporter' #3630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion command/flag/space_role.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ type SpaceRole struct {
}

func (SpaceRole) Complete(prefix string) []flags.Completion {
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor"}, prefix, false)
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor", "SpaceSupporter"}, prefix, false)
}

func (s *SpaceRole) UnmarshalFlag(val string) error {
Expand Down
14 changes: 8 additions & 6 deletions command/flag/space_role_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ var _ = Describe("SpaceRole", func() {
completions := spaceRole.Complete(prefix)
Expect(completions).To(Equal(matches))
},
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 'S'", "S",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 's'", "s",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 'S'", "S",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 's'", "s",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
Entry("completes to 'SpaceAuditor' when passed 'Spacea'", "Spacea",
[]flags.Completion{{Item: "SpaceAuditor"}}),
Entry("completes to 'SpaceDeveloper' when passed 'Spaced'", "Spaced",
Expand All @@ -28,8 +28,10 @@ var _ = Describe("SpaceRole", func() {
[]flags.Completion{{Item: "SpaceManager"}}),
Entry("completes to 'SpaceManager' when passed 'spacEM'", "spacEM",
[]flags.Completion{{Item: "SpaceManager"}}),
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed nothing", "",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
Entry("completes to 'SpaceSupporter' when passed 'Spaces'", "Spaces",
[]flags.Completion{{Item: "SpaceSupporter"}}),
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed nothing", "",
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
Entry("completes to nothing when passed 'wut'", "wut",
[]flags.Completion{}),
)
Expand Down
Loading