Upgrade to golang.org/x/tools v0.39.0 to fix generation #3635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <[email protected]>
anujc25
approved these changes
Nov 21, 2025
Contributor
anujc25
left a comment
anujc25
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
golang.org/x/tools v0.38.0 had broken the Counterfeiter code generation, so before this PR, if you run
go generate ./...you will see errors like these:This PR updates
golang.org/x/toolsto the fixed version v0.39.0.Why Is This PR Valuable?
Fixed code generation
I'm not sure when the generated code is being used, but it is out of date. If it has value, I can push a different PR to update the generate fakes.