Clean up minichlink makefile #764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlohr
reviewed
Nov 17, 2025
| all : $(TOOLS) | ||
|
|
||
| # will need mingw-w64-x86-64-dev gcc-mingw-w64-x86-64 | ||
| minichlink.exe : $(C_S) $(H_S) Makefile |
Owner
There was a problem hiding this comment.
How does the .exe get generated in the new version?
Author
There was a problem hiding this comment.
Make on windows will actually handle this for us. Not specifying an extension leads to generating an exe.
Author
There was a problem hiding this comment.
Likewise commands like rm minichlink will delete minichlink.exe. I can only assume this is intentionally done by mingw devs
cnlohr
reviewed
Nov 17, 2025
| LDFLAGS_WINDOWS:=-L. -lpthread -lusb-1.0 -lsetupapi -lws2_32 | ||
| ifeq ($(OS),Windows_NT) | ||
| TOOLS:=minichlink.exe | ||
| TOOLS:=minichlink minichlink.dll |
Owner
There was a problem hiding this comment.
Doesn't this need to be minichlink.exe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up the Makefile a bit.
From @unicab369 on discord we know that minichlink compiles fine on Clang, so it's safe to not hardcode the compiler and instead pull it from $(CC)
Remove the platform (windows) CFLAGS and LDFLAGS and just override them in the conditional like it's done for macos.
Remove the .exe build instructions. Make on Windows will actually handle this for us. If we're building an executable it will append it with .exe. Likewise for executions, deletions and so on.
Add minichlink.dll to the default build to mirror the steps for *nix. Prior it had to be invoked explicitly.
Remove the makefile itself from rule dependencies. Doesn't hurt but makes no sense. How do we invoke a build step from the makefile without the makefile existing.