Ch32v30x Random Number Genearator test. #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlohr
reviewed
Nov 21, 2025
|
|
||
| RNG->CR &= ~RNG_CR_RNGEN; // Disable RNG | ||
| RNG->SR = 0; // Clear error flags | ||
| Delay_Us(1); // Wait |
Owner
There was a problem hiding this comment.
Cannot wait. Find out what takes time, and what you have to do to make this as fast and clean as possible. Other people will be downstream. this needs to be high quality.
Also since we are doing another round, can these functions be static?
Contributor
Author
There was a problem hiding this comment.
I'm not sure what causes the wait, if I read the register without waiting it doesn't return anything.
Contributor
Author
There was a problem hiding this comment.
Maybe the application code has to keep refresh the reading until they get a number
Contributor
Author
There was a problem hiding this comment.
actually, nvm. I added the delay bc of the while loop, the while loop should block until it finds a new number.
Owner
|
See above comment. |
Owner
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty straight forward as well.