added Ch32v30x PVD test. #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added lib_pvd that share code between the v00x to v30x.
cnlohr
reviewed
Nov 21, 2025
extralibs/lib_pvd.h
Outdated
|
|
||
| #include "ch32fun.h" | ||
|
|
||
| void PVD_init(u8 threshold) { |
cnlohr
reviewed
Nov 21, 2025
extralibs/lib_pvd.h
Outdated
| } | ||
|
|
||
| // Get threshold setting: the PLS[1:0] bits | ||
| u8 PVD_getThreshold() { |
Owner
There was a problem hiding this comment.
in general, make these ints so that the compiler doesn't do any extra masking.
Here, it's fine it's not a big deal, and the compiler will produce fine code, but in other cases it may not.
Owner
|
@unicab369 I really like this, if you can address both comments, that would be great and then I can merge it. |
Owner
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added lib_pvd that share code between the v00x to v30x.