mmaprototype: introduce and adopt mmaload package #157816
Draft
+495
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
tbg
force-pushed
the
mma-check-neg-load
branch
from
1eed891 to
15018e1
Compare
I want to avoid footguns related to negative load values. Having a package for
the load primitives allows hiding the naked slice, so that use from the
mmaprototype package can be enforced to be automatically correct.
This first commit creates the package and moves the LoadValue LoadVector types.
It also creates a SignledLoad{Value,Vector} type that will be adopted as
representation for the adjusted load (which can become negative).
This commit doesn't yet have great comments on the new types and methods.
They're added in a follow-up commit in the same PR - please take a look
at the entire diff first if definitions here are unclear. Sorry about
that - I wasn't able to easily reorder the commits after the fact.
Epic: CRDB-55052
This required an update to and thus review of all arithmetic involving this type (which was part of the point of doing this). A few TODOs were added, and I took the opportunity to refactor the max pending frac computation, which is now much simpler. I'm tracking writing the unit test in cockroachdb#157757. No AI in this workstream so far. Epic: CRDB-55052.
tbg
force-pushed
the
mma-check-neg-load
branch
from
15018e1 to
19fc940
Compare
Member
Author
|
Need to take a step back here. As of this PR, |
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a SignedLoadVector which hides its underlying elements (primarly from the mmaprototype package). Load value arithmetic that could become negative now needs to go through helpers that make it difficult to "forget" that negative values can occur.
This isn't 100% yet, but it's a start.
Informs #157757.
Epic: CRDB-55052