changefeedccl: add metamorphic testing for db-level feeds #157898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
aerfrei
force-pushed
the
db-level-metamorphic-clean
branch
3 times, most recently
from
f564a06 to
887b910
Compare
This change the default initial scan behavior for db-level feeds to not do an initial scan if no option is specified. When an initial scan is specified, that is respected. We do not allow db-level changefeeds with initial_scan='only'. This includes a rewrite of existing db-level feeds tests which rely on default initial scans in their testing. Epic: CRDB-1421 Informs: cockroachdb#156484 Release note: None
aerfrei
force-pushed
the
db-level-metamorphic-clean
branch
2 times, most recently
from
5c2baa4 to
73223a3
Compare
Epic: CRDB-1421 Fixes: cockroachdb#148858
aerfrei
force-pushed
the
db-level-metamorphic-clean
branch
from
73223a3 to
c64b197
Compare
aerfrei
force-pushed
the
db-level-metamorphic-clean
branch
from
2a3d503 to
af0c5bb
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-1421
Fixes: #148858