changefeedccl: change db-level feed default to no initial scan #158104
+352
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
aerfrei
force-pushed
the
db-level-feeds-no-initial-scan-by-default
branch
3 times, most recently
from
5646218 to
dd5ef63
Compare
This change the default initial scan behavior for db-level feeds to not do an initial scan if no option is specified. When an initial scan is specified, that is respected. We do not allow db-level changefeeds with initial_scan='only'. This includes a rewrite of existing db-level feeds tests which rely on default initial scans in their testing. Epic: CRDB-1421 Informs: cockroachdb#156484 Release note: None
aerfrei
force-pushed
the
db-level-feeds-no-initial-scan-by-default
branch
from
dd5ef63 to
10a5244
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the default initial scan behavior for db-level feeds to not do an initial scan if no option is specified. When an option is specified for initial scan, it is respected.
This includes a rewrite of existing db-level feeds tests which rely on default initial scans in their testing.
Epic: CRDB-1421
Informs: #156484
Release note: None