sql: pin read sequence number while draining a WITH HOLD cursor for persistence - #172836
Open
sijie-Z wants to merge 2 commits into
Open
sql: pin read sequence number while draining a WITH HOLD cursor for persistence#172836sijie-Z wants to merge 2 commits into
sijie-Z wants to merge 2 commits into
Conversation
…ersistence persistCursor drains the cursor via bare cursor.Next() calls during the COMMIT phase for WITH HOLD cursors, but never brackets the iteration with SetReadSeqNum / restore. The fetchMoveNodeBase path already does this to preserve Postgres-style cursor sensitivity; persistCursor omits it, so the persisted rows can be stamped with whatever the txn's read seqnum has advanced to since DECLARE. Apply the same pin/restore in persistCursor. Add a logictest regression. Fixes cockroachdb#172772 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Verify that a cursor persisted at COMMIT does not observe writes performed after DECLARE. Without the fix in the previous commit, FETCH ALL returns row 100 alongside 1..11; with the fix, only the DECLARE-time snapshot (rows 1..11) is returned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persistCursor drains the cursor via bare cursor.Next() calls during the
COMMIT phase for WITH HOLD cursors, but never brackets the iteration
with SetReadSeqNum / restore. The fetchMoveNodeBase path already does
this to preserve Postgres-style cursor sensitivity; persistCursor
omits it, so the persisted rows can be stamped with whatever the
txn's read seqnum has advanced to since DECLARE.
Apply the same pin/restore in persistCursor. Add a logictest regression.
Fixes #172772
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com