Skip to content

server/span_stats: fix SkipApproxTotalStats empty-ambiguity opt-out [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #173207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

server/span_stats: fix SkipApproxTotalStats empty-ambiguity opt-out [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #173207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/server/span_stats_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,22 @@ func (s *systemStatusServer) spanStatsFanOut(
}
}

// When a node is designated the MVCC collector for none of its spans,
// we must still tell it to skip MVCC collection entirely. An empty
// SpansRequiringMvcc is indistinguishable from "field not set" in
// proto3 (both serialize to an empty, non-nil list on the receiving
// side), so without SkipMvccStats the node would fall through and
// compute MVCC stats for every span it holds -- the opposite of the
// SkipApproxTotalStats intent. Setting SkipMvccStats makes the
// opt-out unambiguous.
skipMvcc := req.SkipApproxTotalStats && len(spansRequiringMvcc) == 0

resp, err := client.(serverpb.RPCStatusClient).SpanStats(ctx,
&roachpb.SpanStatsRequest{
NodeID: nodeID.String(),
Spans: nodeSpans,
SpansRequiringMvcc: spansRequiringMvcc,
SkipMvccStats: skipMvcc,
})
return resp, err
}
Expand Down