Stop using the shell to run commands - #138
Closed
hhhhhhhhhn wants to merge 2 commits into
Closed
Conversation
This prevents RCE with $(...) syntax, and makes the regex escaping functions unnecessary, and the code slightly cleaner.
myyk
approved these changes
Mar 29, 2023
myyk
left a comment
myyk
left a comment
There was a problem hiding this comment.
This change looks good to me, but it needs to be updated because of MCs.
|
I fixed it in #320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents RCE with $(...) syntax, and makes the regex escaping functions unnecessary, and the code slightly cleaner.