Post-launch fixes: footer, header, sitemap, video poster, eyes flake - #181
Merged
Conversation
Empty tagline/mission fields are an authored choice; per-field default fallbacks would resurrect deleted copy. Whole-footer defaults still cover the Contentful-unavailable path. The logo now links to / with the same accessible name as the header logo.
…s authored Submenus now list the primary target as an authored item, so the auto-added link (falling back to the desktop label) would duplicate it. mobileMenuPrimaryLinkLabel becomes the opt-in switch.
Patterns share the experience content type and carry required slugs, so the slug-only filter was emitting them as pages (~50 sandbox / 29 master entries x 12 locales). componentSettings only exists on patterns; verified the filter works on both spaces and all environments.
…mbnail The maxresdefault placeholder detection needs the poster's onLoad, which never fires when the image completes from cache before hydration — so SD videos can show YouTube's 120x90 placeholder. An authored screenshot bypasses YouTube thumbnails and the detection entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/with the same accessible name as the header logo.mobileMenuPrimaryLinkLabelis authored, since submenus list the target themselves now.componentSettings[exists]=false; verified against all three space/environment combos.