-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Run console to pino #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors console logging throughout the codebase by replacing console methods with pino structured logging. The purpose is to standardize logging practices using pino for better log management, structure, and filtering capabilities.
Key changes:
- Imports pino logger in 135+ files
- Replaces
console.log,console.error,console.warn, andconsole.infowith equivalent pino methods - Maintains existing log levels by mapping console methods to appropriate pino methods
Reviewed Changes
Copilot reviewed 297 out of 312 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/trpc/server/routers/viewer/* | Multiple TRPC router handlers updated to use pino logging |
| packages/prisma/* | Database seeding and utility scripts migrated to pino |
| packages/app-store/* | App store components and services converted to structured logging |
| apps/web/* | Web application components and API routes updated with pino |
| packages/lib/* | Core library functions standardized with pino logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const logger = pino() | ||
|
|
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a naming conflict - both the imported logger and the newly declared pino logger are named 'logger'. This could cause confusion and potential runtime issues.
| const logger = pino() |
| const logger = pino() | ||
|
|
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar naming conflict exists here - both the imported logger and the newly declared pino logger use the same variable name 'logger'.
| const logger = pino() |
| @@ -1,3 +1,5 @@ | |||
| import pino from 'pino' | |||
| const logger = pino() | |||
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another naming conflict between the imported logger and the pino logger constant declared later in the file.
| const logger = pino() | |
| const pinoLogger = pino() |
| @@ -1,6 +1,8 @@ | |||
| import pino from 'pino' | |||
| import { getLocation } from "@calcom/lib/CalEventParser"; | |||
| import logger from "@calcom/lib/logger"; | |||
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming conflict between imported logger and pino logger constant needs to be resolved.
| import logger from "@calcom/lib/logger"; | ||
| import prisma from "@calcom/prisma"; | ||
| import type { | ||
| const logger = pino() |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another instance of naming conflict between the existing logger import and the new pino logger constant.
| const logger = pino() | |
| const pinoLogger = pino() |
70cc1d5 to
5a35797
Compare
This is a pull request for the console to pino workflow