🤖 refactor: unify dropdown/menu surface styling #2120
Conversation
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Follow-up: ModelSelector dropdown had an accidental fixed height ( |
|
ModelSelector follow-up: it was “auto-scrolling” on hover because we always call |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Centralize shared Radix menu/dropdown surface styling and z-index. - Add --z-dropdown CSS token - Add menuStyles helpers and wire Popover/Select/ContextMenu to them --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$n/a`_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=n/a -->
Migrate bespoke dropdowns/menus to use shared menu surface styling (menuSurfaceClassName) and the --z-dropdown token for consistent stacking. Also composes menuItemBaseClassName for interactive rows where appropriate. --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$unknown`_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=unknown -->
jaaydenh
force-pushed
the
refactor/unify-dropdown-menu-styles-2062
branch
from
6b2d8b4 to
13adced
Compare
1 participant
Summary
Unifies dropdown/menu surface styling across the app by introducing shared menu style primitives (surface/item/separator) and a single z-index token, then migrating bespoke dropdown implementations to use them.
Background
Issue: #2062
Implementation
--z-dropdownCSS token (1600) for dropdown/menu overlay stacking.src/browser/components/ui/menuStyles.tswith shared classnames:menuSurfaceClassNamemenuItemBaseClassNamemenuSeparatorClassNameui/popover.tsxui/select.tsxui/context-menu.tsxAgentModePicker,ModelSelector,CommandSuggestions,KebabMenu,BaseSelectorPopover,SectionHeaderValidation
make static-checkRisks
10000+) and now use--z-dropdown(1600). This is intentional for consistency, but could affect stacking relative to other overlays/toasts.Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$6.64