🤖 refactor: move settings from modal to route page (/settings/:section)#2361
Merged
🤖 refactor: move settings from modal to route page (/settings/:section)#2361
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3292741c4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jaaydenh
force-pushed
the
settings-layout-28mw
branch
3 times, most recently
from
3ccf052 to
661f40f
Compare
jaaydenh
force-pushed
the
settings-layout-28mw
branch
from
661f40f to
25852cc
Compare
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25852cc39c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
RouterContext used to snapshot only pathname+search before entering /settings and would
navigate back by URL string alone. That dropped the prior location.state, breaking
/project flows that depend on { projectPath } navigation state (including the legacy
?path= deep link rewrite).
This change snapshots both the URL and location.state, and restores state when leaving
settings. Added a unit test to prevent regressions.
---
_Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$16.46`_
<!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=16.46 -->
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
Settings/index.ts re-exported SettingsPage, SettingsProvider, and useSettings but had zero consumers — all call-sites already import directly from the source modules (SettingsPage.tsx, SettingsContext.tsx). Removing dead code left over from the SettingsModal → SettingsPage rename in #2361.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Settings modal dialog with a full-page Settings experience at
/settings/:section, keeping the app left sidebar visible and hiding the workspace right sidebar.Background
The modal overlay constrained settings layout, fought with focus traps and right-sidebar layering, and couldn't be deep-linked. A route-based page aligns with the existing route-driven architecture (
/workspace/:id,/project) and enables deep-linking from the command palette, keyboard shortcuts, and contextual "open settings" actions.Implementation
5 files changed, +96/−63 lines (net +33)
RouterContext (
src/browser/contexts/RouterContext.tsx)currentSettingsSectionfrom/settings/:sectionURL patternnavigateToSettings(section?)andnavigateFromSettings()helpersSettingsContext (
src/browser/contexts/SettingsContext.tsx)isOpenandactiveSectionare now derived from the route instead of localuseStateopen()/close()/setActiveSection()delegate to router navigationuseSettings().open("providers"), command palette, keyboard shortcut, MCP/Providers prompts) work without modificationprovidersExpandedProviderone-shot hint preserved as local UI stateSettingsPage (
src/browser/components/Settings/SettingsPage.tsx)SettingsModalApp wiring (
src/browser/App.tsx)AppInner's main content area<SettingsModal />mount removedExports (
src/browser/components/Settings/index.ts)SettingsModal→SettingsPageRisks
SettingsContextAPI shape is preserved identically, so all callers continue working. The risk is limited to visual/layout differences vs. the old modal.navigateFromSettings()falls back to/if no prior non-settings route was observed (e.g., app launched directly to a settings URL). This is reasonable behavior but differs from the modal's simple close-overlay behavior.Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$7.91