build(deps): bump golang.org/x/net from 0.47.0 to 0.55.0 - #749
build(deps): bump golang.org/x/net from 0.47.0 to 0.55.0#749dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.47.0 to 0.55.0. - [Commits](golang/net@v0.47.0...v0.55.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.55.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughUpdates ChangesDependency and Go version bump
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 129: The Go toolchain version is out of sync between the module and CI
tooling: go.mod requires Go 1.25.0 while openshift-ci/Dockerfile.tools still
installs Go 1.24.13. Update the Go version used in Dockerfile.tools to match
go.mod, or adjust go.mod to the intended shared version, so the compiler version
is consistent across builds and CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: e4513e1b-fdc4-4dc1-9154-a5b7117f06aa
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
codeready-toolchain/api(manual) → reviewed against open PR#512dependabot/go_modules/golang.org/x/net-0.55.0instead of the default branchcodeready-toolchain/toolchain-common(manual)codeready-toolchain/host-operator(manual)codeready-toolchain/toolchain-e2e(manual)
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: test
- GitHub Check: Build & push operator bundles & dashboard image for e2e tests
⚠️ CI failures not shown inline (2)
GitHub Actions: ci-build / 0_GolangCI Lint.txt: build(deps): bump golang.org/x/net from 0.47.0 to 0.55.0
Conclusion: failure
##[group]run golangci-lint
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint config path --config=./.golangci.yml] in [/home/runner/work/member-operator/member-operator] ...
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint run --config=./.golangci.yml --verbose] in [/home/runner/work/member-operator/member-operator] ...
level=info msg="golangci-lint has version 2.1.6 built with go1.24.2 from eabc2638 on "
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[config_reader] Module name \"github.com/codeready-toolchain/member-operator\""
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
##[error]golangci-lint exit with code 3
GitHub Actions: ci-build / GolangCI Lint: build(deps): bump golang.org/x/net from 0.47.0 to 0.55.0
Conclusion: failure
##[group]run golangci-lint
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint config path --config=./.golangci.yml] in [/home/runner/work/member-operator/member-operator] ...
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint run --config=./.golangci.yml --verbose] in [/home/runner/work/member-operator/member-operator] ...
level=info msg="golangci-lint has version 2.1.6 built with go1.24.2 from eabc2638 on "
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[config_reader] Module name \"github.com/codeready-toolchain/member-operator\""
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
##[error]golangci-lint exit with code 3
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
go.mod
🔀 Multi-repo context
Linked repositories findings
codeready-toolchain/api ([ref: PR branch refs/pull/512/head])
go.mod:41andgo.sum:116-117already pingolang.org/x/net v0.55.0indirectly.- No direct
golang.org/x/net/*imports were found.
codeready-toolchain/toolchain-common
go.mod:41/go.sum:116-117pingolang.org/x/net v0.55.0indirectly.- No direct
golang.org/x/net/*imports were found.
codeready-toolchain/host-operator
go.mod:41/go.sum:116-117pingolang.org/x/net v0.55.0indirectly.- No direct
golang.org/x/net/*imports were found.
codeready-toolchain/toolchain-e2e
go.mod:41/go.sum:116-117pingolang.org/x/net v0.55.0indirectly.- No direct
golang.org/x/net/*imports were found.
🔇 Additional comments (1)
go.mod (1)
101-111: LGTM!
| go 1.24.4 | ||
|
|
||
| toolchain go1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'go.mod version lines:\n'
rg -n '^(go|toolchain)\s+' go.mod || true
printf '\nDocker/tooling Go version pins:\n'
rg -n 'go1\.(24\.13|25\.0)|toolchain go1\.24\.13|toolchain go1\.25\.0|FROM .*go:1\.(24\.13|25\.0)' openshift-ci .github . || true
printf '\nRelevant file contents:\n'
for f in go.mod openshift-ci/Dockerfile.tools; do
if [ -f "$f" ]; then
echo "--- $f ---"
cat -n "$f" | sed -n '1,220p'
fi
doneRepository: codeready-toolchain/member-operator
Length of output: 9692
Align the Go toolchain versions
go.mod now requires Go 1.25.0, but openshift-ci/Dockerfile.tools still downloads Go 1.24.13. Update the image or keep the module version in sync so CI and tooling use the same compiler.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 129, The Go toolchain version is out of sync between the
module and CI tooling: go.mod requires Go 1.25.0 while
openshift-ci/Dockerfile.tools still installs Go 1.24.13. Update the Go version
used in Dockerfile.tools to match go.mod, or adjust go.mod to the intended
shared version, so the compiler version is consistent across builds and CI.
Source: Path instructions
|
|
can't do it now, we need to upgrade to Go 1.25, first |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
2 participants
Bumps golang.org/x/net from 0.47.0 to 0.55.0.
Commits
7770ec4go.mod: update golang.org/x dependencies4ece7b6html: escape greater-than symbol in doctype identifiers08be507html: improve Noah's Ark clause performancea8fb2fehtml: properly render fostered elements in foreign content0dc5b7ahtml: properly check namespace in "in body" any other end taga452f3chtml: ignore duplicate attributes during tokenizationf865199quic: fix appendMaxDataFrame erroneously accumulating sentLimit210ed3cquic: establish a "happened-before" relationship between stream write and readad8140equic: fix buffer slicing when handling overlapping stream data23ee2efhttp2: avoid API changes when built with go1.27Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit