fix(grouper): fix parallel events increment #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaveeks
approved these changes
Sep 30, 2024
TatianaFomina
approved these changes
Sep 30, 2024
neSpecc
added a commit
that referenced
this pull request
Sep 30, 2024
* Changed the content of the limit events email (#319) * Update html.twig Change the description email * Change email's title * Update index.ts (#322) --------- Co-authored-by: Alexander Chernyaev <[email protected]> Co-authored-by: Peter <[email protected]>
nikmel2803
added a commit
that referenced
this pull request
Dec 4, 2024
* Changed the content of the limit events email (#319) * Update html.twig Change the description email * Change email's title * Update index.ts (#322) * add error log (#324) --------- Co-authored-by: Alexander Chernyaev <[email protected]> Co-authored-by: Peter <[email protected]> Co-authored-by: Nikita Melnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When many similar events processed in parallel, check for
isFirstOccurencereturns falsy-false value since we have no db lock. So all second events are processed as the first one.We have a special try-catch statement that handles this case by catching Mongo "duplicate error". This statement re-runs processing for a particular event. But looks like we've lost
returnthere, so on each re-run increment was added anyway