Restrict GITHUB_TOKEN scope in workflows (least privilege)#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: contents: readat the workflow root ofpublish.ymlandtests.yml.actions/missing-workflow-permissions(Fixes in prep for PYPI #1, fixes & migration from /pools #2) flagged in org-wide GitHub Advanced Security scan.Why
Without an explicit
permissions:block, the defaultGITHUB_TOKENinherits whatever the repo/org-wide default is - historicallyread-writeon older orgs. Both jobs only need to read the repo:tests.yml: checks out code and runs pytestpublish.yml: checks out code and uploads to PyPI viaTWINE_USERNAME/TWINE_PASSWORDsecrets (independent ofGITHUB_TOKEN)Test plan
publish.ymlstill publishes to PyPI (TWINE secrets are unaffected byGITHUB_TOKENscope).