Skip to content

Add Rails 8.1 support - #495

Merged
parndt merged 5 commits into
collectiveidea:mainfrom
caonUlisses:main
Dec 20, 2025
Merged

parndt merged 5 commits into
collectiveidea:mainfrom
caonUlisses:main

Conversation

@caonUlisses

Copy link
Copy Markdown
Contributor

This is pretty much a copy of this PR that added rails 8.0 support.

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +103 to +105
- ruby: '3.2'
gemfile: rails_8_1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're now at ruby 3.4

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added ruby 3.4 to the version matrix and included all the supported Ruby version for 8.1 (3.2, 3.3 & 3.4)

@caonUlisses
caonUlisses requested a review from tirinnovo October 28, 2025 13:23
tvdeyen added a commit to AlchemyCMS/alchemy_cms that referenced this pull request Nov 2, 2025
Needs a new version of awesome_nested_set

collectiveidea/awesome_nested_set#495
tvdeyen added a commit to AlchemyCMS/alchemy_cms that referenced this pull request Nov 2, 2025
Needs a new version of awesome_nested_set

collectiveidea/awesome_nested_set#495
tvdeyen added a commit to AlchemyCMS/alchemy_cms that referenced this pull request Nov 2, 2025
Needs a new version of awesome_nested_set

collectiveidea/awesome_nested_set#495
tvdeyen added a commit to AlchemyCMS/alchemy_cms that referenced this pull request Nov 7, 2025
Needs a new version of awesome_nested_set

collectiveidea/awesome_nested_set#495
@sergey-homenko

Copy link
Copy Markdown

Hey @tirinnovo 👋 could you please review this PR again? Thanks 🙏

@alexcastrodev

Copy link
Copy Markdown

Following this thread

@glaszig

glaszig commented Nov 14, 2025

Copy link
Copy Markdown

👀

@maxime-carbonneau maxime-carbonneau mentioned this pull request Nov 25, 2025
@jfi

jfi commented Dec 19, 2025

Copy link
Copy Markdown

@danielmorrison Is this something you can help with, or relax the constraint so we don't hit it on every Rails version upgrade? I'm still using @caonUlisses' fork as I presume are many other people.

This is such a great gem (and integral for lots of us); if there are problems with maintenance or it'd be better forked I'm sure plenty of us—I'd volunteer—would be happy to take on some of that responsibility!

@parndt

parndt commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Did CI run? It's not showing that it ran..

@parndt parndt changed the title Add rails 8.1 support Add Rails 8.1 support Dec 20, 2025
@parndt

parndt commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Apologies everyone - as noted in #496 notifications weren't coming through for this repo for me. I've hopefully fixed that now.

CI's failing quite badly, so I'm looking at it.

Fixed with #497 and #494

@parndt

parndt commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Thanks @caonUlisses !

@parndt
parndt merged commit 111c3f8 into collectiveidea:main Dec 20, 2025
104 checks passed
parndt added a commit that referenced this pull request Dec 20, 2025
These got missed on #495 so adding them in.

I've updated it according to [FastRuby's compatibility matrix](https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html).
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
3.9.0 (2025-12-20)

* Support Rails 8.1 [Ulisses
  Caon](collectiveidea/awesome_nested_set#495)
jperkin pushed a commit to TritonDataCenter/pkgsrc that referenced this pull request May 14, 2026
3.9.0 (2025-12-20)

* Support Rails 8.1 [Ulisses
  Caon](collectiveidea/awesome_nested_set#495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants