Handle every GitHub workflow_run conclusion - #440
Merged
Conversation
ParseGithub only understood "", "success" and "failure". Any other conclusion (cancelled, skipped, timed_out, ...) raised "Unknown status", the webhook 500ed and the Status row kept whatever it had, usually the yellow from the in-progress ping that preceded it. That is how collectiveidea/sidedoor and collectiveidea/kmp-lib got wedged in "building" for months. Now: - "" / nil -> building (yellow), red untouched, as before - success -> green - failure, timed_out, startup_failure -> red - cancelled, skipped, neutral, stale, action_required -> inconclusive: clear yellow, leave red as it was. These say nothing about the health of the branch, so the last real result stands. - anything else -> logged and treated as inconclusive instead of raising, so a new GitHub conclusion can never wedge a row again. Claude-Session: https://claude.ai/code/session_01XpsxmpLCNWZYR8kE6vhM3x
danielmorrison
force-pushed
the
github-conclusions
branch
from
September 3, 2026 15:35
372105b to
32bcbbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseGithubonly understood"","success"and"failure". Any other conclusion (cancelled,skipped,timed_out, ...) raised "Unknown status", the webhook 500ed, and the Status row kept whatever it had, usually the yellow from the in-progress ping that came right before. That is howcollectiveidea/sidedoor(cancelled run on 2025-08-02) andcollectiveidea/kmp-lib(2026-07-18) ended up stuck in "building" for months.Conclusions now map as follows (GitHub's list):
""/nil(still running)successfailure,timed_out,startup_failurecancelled,skipped,neutral,stale,action_requiredThe reasoning for "inconclusive": a cancelled or skipped run says nothing about the health of the branch, so the last real result should stand. Clearing yellow but never touching red means a stray cancel can neither wedge a project in "building" nor hide a real failure.
Test plan
bundle exec rspec(68 examples, 0 failures)bundle exec rake standardhttps://claude.ai/code/session_01XpsxmpLCNWZYR8kE6vhM3x