fix: improve install and add error messages for pre-release drivers#338
Merged
zeroshade merged 2 commits intocolumnar-tech:mainfrom Apr 2, 2026
Merged
Conversation
Member
|
Thanks for doing this! |
Member
Author
|
Updated PR to include coverage for dbc add as well. |
Member
|
What about the case when only pre-release versions are available on the registry, and you already have a pre-release version installed? For example, what should happen when you do: dbc install --pre singlestore
dbc install singlestore |
zeroshade
approved these changes
Apr 2, 2026
Member
Member
Author
|
I don't think that behavior is changed by this PR so I'll create a new issue. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
dbc installanddbc addto provide command suggestions for pre-release drivers.For example: Currently, if I try to dbc install a driver that only has a pre-release available, I get an error message that isn't that helpful,
$ dbc install fakedriver Error: driver `fakedriver` not found (but prerelease versions filtered out)This PR updates the error so it recommends the user try
--pre:This error only happens if the driver only has pre-release versions and the user doesn't specify
--pre. It's not a perfect heuristic but I think it'll work well.