Skip to content

chore: enable removeComments in package tsconfigs #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farnabaz merged 2 commits into from
Sep 4, 2026
Merged

chore: enable removeComments in package tsconfigs #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b3165
use two step build to stripe comments
farnabaz Sep 4, 2026
5e3c7fc
test: update bundle size snapshot
github-actions[bot] Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/comark-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "ngc -p tsconfig.json && node scripts/verify-build.mjs",
"build": "ngc -p tsconfig.json && ngc -p tsconfig.json --removeComments true --declaration false && node scripts/verify-build.mjs",
"dev": "ngc -p tsconfig.json --watch",
"test": "vitest run",
"prepack": "pnpm run build",
Expand Down
4 changes: 2 additions & 2 deletions packages/comark-ansi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/comark-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/comark-nuxt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run --passWithNoTests",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/comark-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/comark-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "svelte-package --input src && node ../../scripts/sync-plugins.mjs",
"build": "svelte-package --input src && svelte-package --input src --types false --preserve-output --tsconfig ./tsconfig.build.json && node ../../scripts/sync-plugins.mjs",
"build:watch": "svelte-package --input src --watch",
"test": "vitest run",
"check": "svelte-check --tsconfig ./tsconfig.json",
Expand Down
18 changes: 18 additions & 0 deletions packages/comark-svelte/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"compilerOptions": {
"target": "es2024",
"lib": ["esnext", "DOM", "DOM.Iterable"],
"module": "esnext",
"moduleResolution": "bundler",
"strict": true,
"strictNullChecks": true,
"esModuleInterop": true,
"skipDefaultLibCheck": true,
"allowImportingTsExtensions": true,
"skipLibCheck": true,
"noEmit": true,
"removeComments": true
},
"include": ["src/**/*"],
"exclude": ["node_modules", "dist"]
}
4 changes: 2 additions & 2 deletions packages/comark-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/comark/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
},
"scripts": {
"stub": "node ../../scripts/stub.mjs",
"build": "tsc",
"build": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"dev": "tsc --watch",
"test": "vitest run",
"prepack": "tsc",
"prepack": "tsc --removeComments --declaration false && tsc --emitDeclarationOnly",
"release": "release-it",
"release:dry": "release-it --dry-run"
},
Expand Down
12 changes: 6 additions & 6 deletions test/bundle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ describe('package bundle size', { timeout: 60_000 }, () => {

expect(report).toMatchInlineSnapshot(`
{
"@comark/angular": "60.6k (70 files)",
"@comark/ansi": "42.0k (98 files)",
"@comark/html": "18.9k (58 files)",
"@comark/angular": "54.0k (70 files)",
"@comark/ansi": "36.6k (98 files)",
"@comark/html": "15.7k (58 files)",
"@comark/nuxt": "11.8k (58 files)",
"@comark/react": "43.6k (74 files)",
"@comark/react": "36.9k (74 files)",
"@comark/svelte": "43.9k (82 files)",
"@comark/vue": "60.5k (78 files)",
"comark": "440k (156 files)",
"@comark/vue": "51.7k (78 files)",
"comark": "363k (156 files)",
}
`)
})
Expand Down
Loading