Integrate redesigned Efficient Sumcheck#24
Merged
Merged
Conversation
Collaborator
Author
|
Pr looks big but it's really only ~100 lines that are different and like a few hundred that are a tiny bit modified to use the API.
I think the right decision in the end is to not have accumulate_sparse_evaluations + batched_constraint_poly in effsc but if it comes up again we could consider something like a crate for |
winderica
approved these changes
Apr 27, 2026
Collaborator
winderica
left a comment
There was a problem hiding this comment.
Super sorry for the delay & awesome work as always!
The changes make perfect sense, and I only have a few (nitpicky) comments about removing unnecessary memory copies, which may or may not make things faster. It's totally fine to ignore them if you think the improvement is marginal!
Co-authored-by: winderica <winderica@gmail.com>
Collaborator
Author
|
Thanks again for the very helpful comments @winderica ! Merging this now |
z-tech
added a commit
that referenced
this pull request
May 12, 2026
Integrate redesigned Efficient Sumcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Based on microbench: Goldilocks hashchain, n=4096, l1=4, s=8, t=7, hash_chain_size=10, 30 iters + 2 warmup.
I have a very large rewrite coming after this btw.