-
Notifications
You must be signed in to change notification settings - Fork 5
Consolidate configurations into pyproject.toml
#367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
from `setup.cfg` to `pyproject.toml`
from `setup.cfg` to `pyproject.toml`
Co-authored-by: Austin Macdonald <austin@dartmouth.edu>
from `tox.ini` to `pyproject.toml`
from `tox.ini` to `pyproject.toml`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage ? 91.19%
=======================================
Files ? 8
Lines ? 1056
Branches ? 138
=======================================
Hits ? 963
Misses ? 70
Partials ? 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates build and tool configurations by migrating settings from setup.cfg and tox.ini into pyproject.toml, following modern Python packaging standards. The migration eliminates setup.cfg entirely while retaining only tox and flake8 configurations in tox.ini (since flake8 doesn't support pyproject.toml).
Changes:
- Migrated all project metadata, dependencies, and entry points from setup.cfg to pyproject.toml
- Moved tool configurations (pytest, mypy, isort, coverage) from tox.ini to pyproject.toml
- Updated project description and adjusted project URL keys
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyproject.toml | Added complete project metadata, optional dependencies, scripts, and tool configurations (pytest, mypy, isort, coverage, setuptools) |
| setup.cfg | Removed entirely - all configurations migrated to pyproject.toml |
| tox.ini | Removed migrated configurations (pytest, coverage, isort) while keeping tox and flake8 configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
from `tox.ini` to `pyproject.toml`
1ad3258 to
1c014d0
Compare
|
@asmacdo please re-review |
asmacdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @candleindark!
This PR closes #324. It move all configurations from
setup.cfgtopyproject.tomland some configurations intox.initopyproject.toml. The only configurations that remain intox.iniare the ones for tox and flake8. The configurations for flake8 are not supported to be expressed inpyproject.toml. As for the configurations for tox, they seems to be more intuitive to stay in tox.ini, moving them over topyproject.tomlwill significantly enlarge it.Additionally, this PR also includes the following adjustments.
pyproject.toml.[project.urls]inpyproject.tomlhave been adjusted to well-known labels.TODO: