Convert NieuwbouwOffice to a Saloon connector#1
Merged
jhhazelaar merged 2 commits intomainfrom May 5, 2026
Merged
Conversation
Add saloonphp/saloon as a runtime dependency and turn the SDK entry point into a Connector with a default https://api.nbo.nl/rest base URL, JSON accept header, automatic error throwing, and apikey-prefixed token auth. Replace the example test with focused tests covering base URL handling, authenticator configuration, and outgoing request headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saloonphp/saloonas a runtime dependencyNieuwbouwOfficeinto aSaloon\Http\Connectorwith sensible defaultsDetails
NieuwbouwOfficenow extendsSaloon\Http\Connectorand uses theAcceptsJsonandAlwaysThrowOnErrorsplugins.$tokenand an optional$baseUrl(defaults tohttps://api.nbo.nl/rest) so staging/test environments can override it.defaultAuth()returns aTokenAuthenticatorwith theapikeyprefix, so requests are sent withAuthorization: apikey <token>instead ofBearer <token>.Tests
Connector.Authorization: apikey <token>andAccept: application/jsonheaders viacreatePendingRequest().All 7 tests pass locally with
vendor/bin/pest.