feat: add Task.RuntimeMetadata for host-resolved worker secrets - #154
Merged
NicholasDCole merged 5 commits intoJul 29, 2026
Merged
Conversation
The server can resolve a worker's declared TaskDef.runtimeMetadata secret names at poll time and deliver the values on the wire-only Task.runtimeMetadata (conductor-oss PR #1255) — never persisted to task input. Add the field to the client Task model so it is not dropped on deserialization. - Dictionary<string,string> RuntimeMetadata with [DataMember(Name="runtimeMetadata", EmitDefaultValue=false)] (empty omitted; [DataContract] makes Newtonsoft honor it). - Wired into the constructor, ToString, Equals, and GetHashCode like OutputData. - Tests/Client/TaskRuntimeMetadataTests.cs: round-trips and omit-when-empty. Note: not built/tested locally (no dotnet in the authoring environment); relies on CI for the build + test run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
kowser-orkes
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Task.RuntimeMetadata(Dictionary<string, string>) so the C# SDK preserves host-resolved worker secrets delivered on the wire-onlyruntimeMetadatafield when a worker polls a SIMPLE task.Why
The server resolves names declared in
TaskDef.runtimeMetadataat poll time. Before this change, the C# client silently dropped those values during task deserialization.Validation
Local smoke against
http://localhost:8080/apiusing the samecheck_secretSIMPLE task:mainRuntimeMetadatais absent.DEMO_SECRET=demovalue12345throughTask.RuntimeMetadata.Both workers completed successfully. The targeted serialization tests are included in this PR.
UI evidence
Main — runtime metadata unavailable
This PR — runtime metadata delivered