Skip to content

fix(scheduler): fall back from PUT to GET on pause/resume 405 - #170

Merged
kowser-orkes merged 1 commit into
mainfrom
fix/scheduler-verb-fallback
Aug 7, 2026
Merged

fix(scheduler): fall back from PUT to GET on pause/resume 405#170
kowser-orkes merged 1 commit into
mainfrom
fix/scheduler-verb-fallback

Conversation

@kowser-orkes

Copy link
Copy Markdown
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

  • Schedule pause/resume verb differs by server family (OSS/embedded Conductor accepts PUT only,
    Orkes Conductor historically accepted GET only) — both SchedulerResourceApi (the generated
    client) and Schedules (the AI scheduling facade) sent a single hardcoded verb, so each only
    worked against one server family
  • Both now try PUT first on every call, falling back to GET only on a 405 — no cached state, no
    shared verdict between pause and resume
  • Any other error status (403, 404, 5xx) propagates immediately, no fallback attempted
  • No public API changes — same method signatures, same return types, same exceptions on real
    failures

Alternatives considered

  • Switch the hardcoded verb from GET to PUT outright — rejected, breaks any Orkes deployment
    that hasn't picked up server-side PUT support yet
  • Cache the fallback verdict per client instance (matching the Java SDK client) — rejected in
    favor of a simpler, stateless per-call retry

- try PUT first, fall back to GET on 405, cache the verdict per client instance
@kowser-orkes
kowser-orkes force-pushed the fix/scheduler-verb-fallback branch from 5ec82f6 to 947db96 Compare August 7, 2026 06:53

@chrishagglund-ship-it chrishagglund-ship-it left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kowser-orkes
kowser-orkes merged commit ab5b8f7 into main Aug 7, 2026
7 checks passed
@kowser-orkes
kowser-orkes deleted the fix/scheduler-verb-fallback branch August 7, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants