Test gap: no coverage for resolvePassphrase() (src/batch-tx.ts)

[Jaydbrown]

resolvePassphrase() in src/batch-tx.ts — which resolves a BatchTransactionContext's effective network passphrase from either an explicit networkPassphrase or a named network, and throws BatchBuildError for an unknown network — has no dedicated test under src/tests/. It's a small pure function with several distinct branches (explicit passphrase present/blank, named network known/unknown, neither provided) that would be cheap to cover directly rather than relying on it being exercised incidentally through buildBatchTransactionsSync/buildBatchTransactions tests.

[bobo-24]

Hi! I came across this issue and would love to work on it. I have experience with similar tasks and I'm confident I can investigate, implement a clean solution, and thoroughly test it before submitting a PR. If the issue is still open, I would appreciate it if you could assign it to me. I’ll prioritize this immediately and ensure a reliable solution is delivered as soon as possible. Thank you!

[Sweet-16]

@Sweet-16 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’ve read through the issue details and can deliver a solution that meets your requirements. Kindly assign this to me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Sweet-16 to this issue.

[kamolideen8k-star]

@kamolideen8k-star has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi there! I’ve carefully gone through the issue and would be happy to work on it. I’m confident in my ability to understand the requirements, address the necessary changes, and deliver a solution that meets the acceptance criteria. I’ll ensure the implementation is well-structured and properly tested before submitting the final pull request. Kindly consider assigning this issue to me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kamolideen8k-star to this issue.

[001marvelqueen-blip]

@001marvelqueen-blip has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I'd like to work on this issue because resolvePassphrase() currently lacks dedicated test coverage, leaving an important part of the batch transaction flow vulnerable to regressions. Since passphrase resolution can affect transaction authorization and execution, testing its behavior is important for both reliability and security.

I have experience writing automated tests for TypeScript applications, transaction workflows, and security-sensitive logic.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @001marvelqueen-blip to this issue.

[thelight08]

@thelight08 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I'd be glad to handle this issue. I'll keep the implementation concise, maintainable, and well-documented

ℹ️ Repo Maintainers: To accept this application, review their application or assign @thelight08 to this issue.

[iammrjude]

@iammrjude has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on issue #462.

I’ll add focused, table-driven tests for every branch of resolvePassphrase() in src/batch-tx.ts, including:

• A valid explicit networkPassphrase
• Precedence of an explicit passphrase when network is also provided
• Blank or whitespace-only explicit passphrases
• Each supported named network
• An unknown network producing the expected BatchBuildError
• A context containing neither a usable passphrase nor a network

I’ll follow the repository’s existing test conventions and test the function directly, keeping the suite deterministic and independent of network services. I’ll also verify exact return values and relevant error details rather than only asserting that an exception occurs.

If direct testing requires exposing the helper or making a small structural change, I’ll keep the refactor minimal and preserve existing runtime behavior. The PR will contain the test results and Closes #462.

Please assign this issue to me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @iammrjude to this issue.

[Joeloo1]

@Joeloo1 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on this issue. Please assign it to me. Thanks!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Joeloo1 to this issue.

[pyper01]

@pyper01 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

i will like to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @pyper01 to this issue.

[drips-wave]

Congratulations, @pyper01! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @pyper01: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @pyper01 as part of the Stellar Wave Program's 8th Wave 🥳

😎 @pyper01: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.