Skip to content

[DP-19090] Migrate Windows CI jobs from Windows 2019 to Windows 2025#3406

Merged
Corey Christous (cchristous) merged 2 commits into
mainfrom
cchristous-migrate-windows-2025
Jun 9, 2026
Merged

[DP-19090] Migrate Windows CI jobs from Windows 2019 to Windows 2025#3406
Corey Christous (cchristous) merged 2 commits into
mainfrom
cchristous-migrate-windows-2025

Conversation

@cchristous

Copy link
Copy Markdown
Member

Change Description

Migrates the two Windows pool references in this repo from s1-prod-windows (Windows Server 2019) to s1-windows-2025-amd64-4 (Windows Server 2025):

  • .semaphore/semaphore.yml — the Windows x64 Stable: Tests block (runs on PR pushes; gated only by the release-marker skip: clause that does not apply to this change).
  • .semaphore/playwright-e2e.yml — the parameterized Windows x64: Playwright E2E Tests block (manual / scheduled task pipeline).

Why this is the right change:

Why this is safe:

  • Both changes touch only agent.machine.type; no commands, prologue, dependencies, or job structure are modified.
  • The Windows blocks use npm, npx, choco, gh, and make — all toolchain-portable and not pinned to a specific Windows SDK version.
  • Reverting either single-line change immediately restores the previous pool if any regression is observed.

Testing

  • The Windows x64 Stable: Tests block in semaphore.yml will run on this PR (the skip: only fires on release.svg / .versions/next.txt changes, neither of which are touched here). Look for that block to pass on the new agent.
  • playwright-e2e.yml is parameterized and not triggered on PR; it will be exercised the next time the manual/scheduled task runs after merge.
  • No effect on Linux x64 / Linux ARM64 / macOS blocks.

Switch both Windows-pool references from s1-prod-windows (Windows 2019)
to s1-windows-2025-amd64-4 (Windows 2025):

- .semaphore/semaphore.yml: the 'Windows x64 Stable: Tests' block that
  runs on PR pushes.
- .semaphore/playwright-e2e.yml: the parameterized Windows E2E pipeline
  (manual / scheduled task).

Per the Builds team Windows 2025 rollout.
Copilot AI review requested due to automatic review settings May 27, 2026 15:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the two Windows Semaphore CI agent pool references from the aging s1-prod-windows (Windows Server 2019) to s1-windows-2025-amd64-4 (Windows Server 2025), aligning with the org-wide rollout to a supported baseline OS image.

Changes:

  • Update Windows stable test block agent type in .semaphore/semaphore.yml.
  • Update Windows Playwright E2E block agent type in .semaphore/playwright-e2e.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.semaphore/semaphore.yml Switches PR-gated Windows x64 Stable Tests block to the Windows Server 2025 pool.
.semaphore/playwright-e2e.yml Switches parameterized/scheduled Windows Playwright E2E block to the Windows Server 2025 pool.

@sonarqube-confluent

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@cchristous Corey Christous (cchristous) changed the title Migrate Windows CI jobs from Windows 2019 to Windows 2025 [DP-19090] Migrate Windows CI jobs from Windows 2019 to Windows 2025 Jun 3, 2026
@sonarqube-confluent

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@cchristous

Copy link
Copy Markdown
Member Author

🤖 Review Hub assignments

@dtxDave Shoup (@shouples)
Top-scored candidate (rank 1 of 13). Team was explicitly requested on this PR.

Scoring breakdown for Dave Shoup (@shouples)
Factor Score
Familiarity 46
Load penalty -8
Round-robin 0
Total 38

Generated by Review Hub. This comment is rewritten on each (re)assignment.

@cchristous Corey Christous (cchristous) enabled auto-merge (squash) June 9, 2026 01:00
@cchristous Corey Christous (cchristous) merged commit ea1f124 into main Jun 9, 2026
14 checks passed
@cchristous Corey Christous (cchristous) deleted the cchristous-migrate-windows-2025 branch June 9, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-hub:assigned Applied by Review Hub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants