upstream: Add proxy cache hit/miss metrics (goharbor/harbor#23578) - #547
Open
github-actions[bot] wants to merge 1 commit into
Open
upstream: Add proxy cache hit/miss metrics (goharbor/harbor#23578)#547github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add http_registry_proxy_requests_total and http_registry_proxy_upstream_requests_total counters to measure proxy cache effectiveness, counted by project type with the repository label dropped to bound metric cardinality. Fixes #22799 Signed-off-by: Jason Lee <jasoneugenelee@gmail.com> (cherry picked from commit f7c9eda10ddb8a8289b5bc758bd8f31fd5594e93) Upstream-Commit: f7c9eda10ddb8a8289b5bc758bd8f31fd5594e93 Upstream-PR: goharbor/harbor#23578 Upstream-Author: @Jason-Lee3 Cherry-Pick-Status: clean Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks upstream Harbor commit
f7c9eda10from goharbor/harbor#23578.Upstream Context
Cherry-Pick Status
Upstream Description
Comprehensive Summary of your change
Added
http_registry_proxy_requests_totalandhttp_registry_proxy_upstream_requests_totalmetrics to monitor proxy cache hit/miss ratio.Issue being fixed
Fixes goharbor/harbor#22799
Please indicate you've done the following:
Review Notes
Upstream-Commit: f7c9eda10ddb8a8289b5bc758bd8f31fd5594e93
Upstream-PR: goharbor/harbor#23578
Cherry-Pick-Status: clean