[WIP] chore(test): renaming classes appropriately, reshufling test logic into main for loop #3843
Conversation
danivilla9
left a comment
danivilla9
left a comment
There was a problem hiding this comment.
The changes so far make sense to me.
One tiny nitpick is that I think that you have an extra 'l' in 'guilderails'
ScrewTSW
force-pushed
the
3642-integrate-all-possible-tests-into-ai.json-execution-format
branch
3 times, most recently
from
317f4c7 to
563dff7
Compare
…to main for loop Signed-off-by: Tibor Dancs <[email protected]>
ScrewTSW
force-pushed
the
3642-integrate-all-possible-tests-into-ai.json-execution-format
branch
from
563dff7 to
a04c903
Compare
Signed-off-by: Tibor Dancs (tdancs old laptop podman-desktop windows testing) <[email protected]>
| await aiLabPage.navigationBar.waitForLoad(); | ||
| }, | ||
| ); | ||
| test.skip(true, `Skipping test due to https://github.com/containers/podman-desktop-extension-ai-lab/issues/3406`); |
There was a problem hiding this comment.
I would not skip whole suite, you still can run 2/5? test cases and check the api endpoints for ai lab.
| * Model Download | ||
| */ | ||
| test.describe.serial(`Download model ${appModel} via AI Lab Catalog`, () => { | ||
| test(`Open AI Lab Catalog`, async ({ runner, page, navigationBar }) => { |
There was a problem hiding this comment.
Why to you change the hook into test case? Still can be a hook for all tests in this sub-suite.
There was a problem hiding this comment.
Since downloading of a model is a prerequisite to all subsequent tests, it might be converted into fixture.
| }, | ||
| ); | ||
| test.skip(true, `Skipping test due to https://github.com/containers/podman-desktop-extension-ai-lab/issues/3406`); | ||
| test('Get AI Lab extension version and open AI Lab navigation bar', async ({ page, runner, navigationBar }) => { |
There was a problem hiding this comment.
why do you change the before hook into test case?
|
|
||
| AI_APP_MODEL_AND_NAMES.forEach((appNames, appModel) => { | ||
| /* eslint-disable sonarjs/no-nested-functions */ | ||
| test.describe.serial(`AI Recipe installations for ${appModel}`, { tag: '@smoke' }, () => { |
There was a problem hiding this comment.
The suite name should be more general, we test a lot of stuff here.
Signed-off-by: Tibor Dancs (tdancs old laptop podman-desktop windows testing) <[email protected]>
3 participants
What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
#3642
How to test this PR?