Skip to content

selinux: Allow qm systemd to signal readiness of container - #992

Merged
alexlarsson merged 1 commit into
mainfrom
add-selinux-sd-notify
Oct 15, 2026
Merged

alexlarsson merged 1 commit into
mainfrom
add-selinux-sd-notify

Conversation

@alexlarsson

@alexlarsson alexlarsson commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

This is needed for my new qm launch experiment. Without it systemd tried to signal readiness when it reached the final state, but that failed with an AVC.

Summary by Sourcery

Permit qm systemd to signal container readiness through the SELinux policy.

New Features:

  • Allow the qm systemd service to signal container readiness under SELinux.

Bug Fixes:

  • Prevent readiness signaling from being denied by an SELinux AVC.

@sourcery-ai

sourcery-ai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the SELinux interface policy to allow qm systemd to signal container readiness, preventing the AVC that blocked systemd readiness notification during the qm launch experiment.

File-Level Changes

Change Details Files
Permit the qm systemd domain to signal container-related services so readiness notification can complete without an SELinux denial.
  • Add the SELinux policy rule needed for qm systemd readiness signaling.
  • Update the interface policy definition in qm.if.
qm.if

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

This is needed for my new qm launch experiment.

Signed-off-by: Alexander Larsson <alexl@redhat.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@alexlarsson
alexlarsson force-pushed the add-selinux-sd-notify branch from 026c1f3 to bd3d57c Compare October 14, 2026 14:07
@alexlarsson
alexlarsson merged commit 0ce7c1a into main Oct 15, 2026
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants