fix: incorrect ordering of links #339
Open
Imanpal Singh (imanpalsingh) wants to merge 4 commits into
Open
Conversation
The addLinksFromRichTextNode crawls through the nodes and always picks up the last item in that array. This causes links to be entity links to be generated in the incorrect order. Instead of taking the last node, the first one is picked up to parse the nodes in the order they appeared in the rich text
Imanpal Singh (imanpalsingh)
force-pushed
the
fix-wrong-order-of-links
branch
from
5ad501f to
b44024f
Compare
Imanpal Singh (imanpalsingh)
changed the title
Shyam Gupta (sshyam-gupta)
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addLinksFromRichTextNodecrawls through the nodes and always picks up the last item in that array. This causes links to be entity links to be generated in the incorrect order.Instead of taking the last node, the first one is picked up to parse the nodes in the order they appeared in the rich text.