Skip to content

fix(security): allow C++ source files in Private directories #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuparvaCode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): allow C++ source files in Private directories #13426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a83cc
fix(security): allow C++ source files in Private directories
SuparvaCode Oct 25, 2026
7e8c47f
chore: format with prettier
SuparvaCode Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/indexing/ignore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,21 @@ export function isSecurityConcern(filePathOrUri: string) {
try {
filepath = fileURLToPath(filePathOrUri);
} catch {}

const normalized = filepath.replace(/\\/g, "/");
const isSourceInPrivate =
/(?:^|\/)Source\/[^/]+\/Private\//i.test(normalized) ||
/(?:^|\/)Private\/.*?\.(?:cpp|cc|cxx|c|h|hpp|hxx|inl|cs)$/i.test(
normalized,
);

if (isSourceInPrivate) {
const basename = path.basename(filepath);
if (!defaultSecurityIgnoreFile.ignores(basename)) {
return false;
}
}

if (path.isAbsolute(filepath)) {
const dir = path.dirname(filepath).split(/\/|\\/).at(-1) ?? "";
const basename = path.basename(filepath);
Expand Down
25 changes: 25 additions & 0 deletions core/indexing/ignore.vitest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,31 @@ describe("isSecurityConcern", () => {
expect(isSecurityConcern("styles/main.css")).toBe(false);
});

it("should not flag C++ source files in Unreal Engine and Private directories", () => {
expect(
isSecurityConcern("Source/ExampleModule/Private/ExampleActor.cpp"),
).toBe(false);
expect(
isSecurityConcern("Source/ExampleModule/Private/ExampleActor.h"),
).toBe(false);
expect(
isSecurityConcern(
"Source/ExampleModule/Private/Subdir/ExampleActor.cpp",
),
).toBe(false);
expect(
isSecurityConcern(
"c:/Users/name/Documents/ExampleProject/Source/ExampleModule/Private/ExampleActor.cpp",
),
).toBe(false);
expect(isSecurityConcern("Private/MyActor.cpp")).toBe(false);
expect(isSecurityConcern("Private/MyActor.h")).toBe(false);
expect(isSecurityConcern("Source/ExampleModule/Private/secret.key")).toBe(
true,
);
expect(isSecurityConcern("Private/.env")).toBe(true);
});

it("should not flag regular configuration files", () => {
expect(isSecurityConcern("package.json")).toBe(false);
expect(isSecurityConcern("tsconfig.json")).toBe(false);
Expand Down
Loading