Skip to content

Fix CLI argument types #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
coopbri wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix CLI argument types #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef3afe
fix: type args
coopbri Oct 8, 2023
536f67b
chore(yarn): update lock file
coopbri Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/knit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ if (process.argv.includes("--quiet") || rcArgs.quiet) {
}

const getPublishOptions = (
// TODO type
argv: any,
override: Partial<PublishPackageOptions> = {},
): PublishPackageOptions => {
Expand Down Expand Up @@ -139,7 +140,7 @@ void yargs
showInstallations({ packages });
break;
case "clean":
await cleanInstallations({ packages, dry: argv.dry });
await cleanInstallations({ packages, dry: !!argv.dry });
break;
default:
console.info("Need installation action: show | clean");
Expand Down Expand Up @@ -261,7 +262,7 @@ void yargs
}
checkManifest({
commit: argv.commit,
all: argv.all,
all: !!argv.all,
workingDir: process.cwd(),
});
},
Expand Down
6 changes: 4 additions & 2 deletions src/rc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@ const validFlags = [

const fileName = ".knitrc";

const readFile = (): Record<string, string | boolean> | null => {
type Config = Record<string, boolean>;

const readFile = (): Config | null => {
if (existsSync(fileName)) {
return parse(readFileSync(fileName, "utf-8"));
}
return null;
};

export const readRcConfig = (): Record<string, string | boolean> => {
export const readRcConfig = (): Config => {
const rcOptions = readFile();
if (!rcOptions) return {};

Expand Down
Loading