feat: migrate to idetik core#7
Open
shlomnissan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
this PR replaces
idetik/reactwith the latest version of idetik core. this isneeded because
idetik/reactuses an older, incompatible version of idetik andis no longer maintained.
the change required a significant rewrite, but functionality remains the same.
the architecture is more robust, the application is stable and functions correctly,
and it's overall much faster. i haven't tested the API endpoints, but this change
doesn't touch that code, so it should still be working correctly.
@utz take your time reviewing this change and confirm everything works as expected. i'm almost done with selectable slice orientations in idetik; once that feature lands i'll post a copick patch directly.