Fix graphical vga mode scaling on loading states#1576
Open
JoeOsborn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue similar to the one described in PR 1123. While using VGA text mode, if I made a save state during text mode and started a fullscreen game that was at a different resolution, then when I loaded the state the canvas size (notably its actual size, not its style) would still be set to a smaller value. This is because the number of rows and columns did not actually change, so the text mode display was not refreshed. I fixed this by adding a
forceparameter to the involved functions to give a way to ensure that the settings were refreshed even if it seemed locally to the screen code like a no-op.